less flakiness in rex module #17519
Open
less flakiness in rex module #17519
+2
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondrejk
added
CherryPick
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
lhellebr
approved these changes
Feb 5, 2025
| @@ -882,7 +870,7 @@ def test_positive_time_expressions(self, rex_contenthost, target_sat): | |||
| ) | |||
|
|
|||
| @pytest.mark.tier3 | |||
| @pytest.mark.rhel_ver_list([8]) | |||
| @pytest.mark.rhel_ver_list([9]) | |||
There was a problem hiding this comment.
Suggested change
| @pytest.mark.rhel_ver_list([9]) | |
| @pytest.mark.rhel_ver_list([settings.content_host.default_rhel_version]) |
Comment on lines
901
to
+902
| sleep(30) | ||
| assert_job_invocation_result(target_sat, invocation_command['id'], client.hostname) | ||
| assert invocation_info['status'] in ['running', 'finished', 'queued'] |
There was a problem hiding this comment.
Instead of using sleep func here, why not use wait_for here to check if job-invocation is finished?
Comment on lines
-843
to
-848
| # 23 mins after every other hour | ||
| [ | ||
| '23 0-23/2 * * *', | ||
| f'{today.strftime("%Y/%m/%d")} ' | ||
| f'{(str(hour if hour % 2 == 0 else hour + 1)).rjust(2, "0")}:23:00', | ||
| ], |
There was a problem hiding this comment.
Could you add some description/comments about this removals?
vijaysawant
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Trying to make a couple of problematic tests behave more predictably.
Solution
Asserting for rex status instead of result, removing some time assertions
Related Issues